Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/grow 284.add amplitude to inkeep actions #176

Merged
merged 20 commits into from
Dec 3, 2024
Merged

Feat/grow 284.add amplitude to inkeep actions #176

merged 20 commits into from
Dec 3, 2024
+28 −14

Conversation

hba-fingerprint
Copy link
Contributor

No description provided.

@JuroUhlar
Copy link
Collaborator

@hba-fingerprint Your lint and tests are failing, please fix them :)

@hba-fingerprint hba-fingerprint force-pushed the feat/GROW-284.add_amplitude_to_inkeep_actions branch from a71b6fa to 13f2b2d Compare November 18, 2024 17:42
@hba-fingerprint hba-fingerprint force-pushed the feat/GROW-284.add_amplitude_to_inkeep_actions branch from 13f2b2d to 760647e Compare November 18, 2024 17:51
necipallef
necipallef previously approved these changes Nov 20, 2024
View reviewed changes
src/client/thirdParty/Amplitude.tsx Outdated Show resolved Hide resolved
src/client/thirdParty/Inkeep.tsx Outdated Show resolved Hide resolved
JuroUhlar
JuroUhlar requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@JuroUhlar JuroUhlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thank you! :)

@hba-fingerprint
Copy link
Contributor Author

Cool, will review everything. Thanks!

JuroUhlar
JuroUhlar requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@JuroUhlar JuroUhlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better already! Left a second round of comments

@hba-fingerprint hba-fingerprint force-pushed the feat/GROW-284.add_amplitude_to_inkeep_actions branch from 09de219 to 5488cd0 Compare November 27, 2024 23:25
@hba-fingerprint hba-fingerprint force-pushed the feat/GROW-284.add_amplitude_to_inkeep_actions branch from 8d2d259 to 9a8ee0b Compare November 28, 2024 11:32
hba-fingerprint and others added 3 commits November 28, 2024 14:30
@hba-fingerprint
feat: GROW-284 - remove visitorId from event properties
3bd4174
@hba-fingerprint
Merge remote-tracking branch 'origin/feat/GROW-284.add_amplitude_to_i…
bf9657a 
…nkeep_actions' into feat/GROW-284.add_amplitude_to_inkeep_actions

# Conflicts:
#	src/client/thirdParty/Amplitude.tsx
#	src/client/thirdParty/Inkeep.tsx
@JuroUhlar
fix: remove any type
bb57d64
JuroUhlar
JuroUhlar reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@JuroUhlar JuroUhlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilfa I am happy with the PR state now, could you take a second look? Thank you!

@JuroUhlar JuroUhlar merged commit 9eba74d into main Dec 3, 2024
5 checks passed
@JuroUhlar JuroUhlar deleted the feat/GROW-284.add_amplitude_to_inkeep_actions branch December 3, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaciesh Zaciesh Zaciesh left review comments

@TheUnderScorer TheUnderScorer TheUnderScorer approved these changes

@JuroUhlar JuroUhlar JuroUhlar approved these changes

@ilfa ilfa ilfa approved these changes

@necipallef necipallef necipallef left review comments

@makma makma Awaiting requested review from makma makma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hba-fingerprint @JuroUhlar @ilfa @necipallef @TheUnderScorer @Zaciesh